Re: [PATCH v2 1/6] dt-bindings: leds: Document TI LM3533 LED controller
From: Daniel Thompson <hidden>
Date: 2026-05-29 10:46:20
Also in:
dri-devel, linux-devicetree, linux-iio, linux-leds, lkml
On Fri, May 29, 2026 at 01:07:50PM +0300, Svyatoslav Ryhel wrote:
пт, 29 трав. 2026 р. о 12:51 Daniel Thompson [off-list ref] пише:quoted
On Thu, May 28, 2026 at 04:51:18PM +0300, Svyatoslav Ryhel wrote:quoted
Document the LM3533 - a complete power source for backlight, keypad and indicator LEDs in smartphone handsets. The high-voltage inductive boost converter provides the power for two series LED strings display backlight and keypad functions. Signed-off-by: Svyatoslav Ryhel <redacted> --- .../leds/backlight/ti,lm3533-backlight.yaml | 68 +++++++ .../bindings/leds/ti,lm3533-leds.yaml | 66 +++++++ .../devicetree/bindings/leds/ti,lm3533.yaml | 170 ++++++++++++++++++ 3 files changed, 304 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/ti,lm3533-backlight.yaml create mode 100644 Documentation/devicetree/bindings/leds/ti,lm3533-leds.yaml create mode 100644 Documentation/devicetree/bindings/leds/ti,lm3533.yamldiff --git a/Documentation/devicetree/bindings/leds/backlight/ti,lm3533-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/ti,lm3533-backlight.yaml new file mode 100644 index 000000000000..866b0fb8ed04 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/backlight/ti,lm3533-backlight.yaml@@ -0,0 +1,68 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/backlight/ti,lm3533-backlight.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI LM3533 high voltage series LED strings + +description: + This is part of the TI LM3533 MFD device. It represents two high voltage series + LED strings for display backlight controlled by the TI LM3533. + +maintainers: + - Svyatoslav Ryhel <clamor95@gmail.com> + +allOf: + - $ref: /schemas/leds/backlight/common.yaml# + +properties: + compatible: + const: ti,lm3533-backlight + + reg: + description: Control bank selection (0 = bank A, 1 = bank B). + maximum: 1 <snip> + ti,pwm-config-mask: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Control Bank PWM Configuration Register mask that allows to configure + PWM input in Zones 0-4 + BIT(0) - PWM Input is enabled + BIT(1) - PWM Input is enabled in Zone 0 + BIT(2) - PWM Input is enabled in Zone 1 + BIT(3) - PWM Input is enabled in Zone 2 + BIT(4) - PWM Input is enabled in Zone 3 + BIT(5) - PWM Input is enabled in Zone 4This is optional and the drive implements a default (zero) that is not documented here. Is zero a sane default from a DT binding point of view?Yes, if property is missing then PWM input is disabled which is equivalent to setting all bits to 0.
So the default should be documented in the bindings? Daniel.