[PATCH v2] staging: sm750fb: remove unused variable
From: Onish Sharma <hidden>
Date: 2026-05-29 10:12:54
Also in:
linux-staging, lkml
Subsystem:
staging - silicon motion sm750 frame buffer driver, staging subsystem, the rest · Maintainers:
Sudip Mukherjee, Teddy Wang, Greg Kroah-Hartman, Linus Torvalds
Remove the set_all_eng_off flag and its associated cleanup logic. The variable is redundant as the hardware should be initialized to a known state regardless of prior usage. Suggested-by: Dan Carpenter <redacted> Signed-off-by: Onish Sharma <redacted> --- drivers/staging/sm750fb/ddk750_chip.c | 28 --------------------------- drivers/staging/sm750fb/ddk750_chip.h | 7 ------- drivers/staging/sm750fb/sm750.c | 1 - drivers/staging/sm750fb/sm750.h | 1 - 4 files changed, 37 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 0bb56bbec43f..553654a77170 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c@@ -262,34 +262,6 @@ int ddk750_init_hw(struct initchip_param *p_init_param) reg |= MISC_CTRL_LOCALMEM_RESET; poke32(MISC_CTRL, reg); } - - if (p_init_param->set_all_eng_off == 1) { - sm750_enable_2d_engine(0); - - /* Disable Overlay, if a former application left it on */ - reg = peek32(VIDEO_DISPLAY_CTRL); - reg &= ~DISPLAY_CTRL_PLANE; - poke32(VIDEO_DISPLAY_CTRL, reg); - - /* Disable video alpha, if a former application left it on */ - reg = peek32(VIDEO_ALPHA_DISPLAY_CTRL); - reg &= ~DISPLAY_CTRL_PLANE; - poke32(VIDEO_ALPHA_DISPLAY_CTRL, reg); - - /* Disable alpha plane, if a former application left it on */ - reg = peek32(ALPHA_DISPLAY_CTRL); - reg &= ~DISPLAY_CTRL_PLANE; - poke32(ALPHA_DISPLAY_CTRL, reg); - - /* Disable DMA Channel, if a former application left it on */ - reg = peek32(DMA_ABORT_INTERRUPT); - reg |= DMA_ABORT_INTERRUPT_ABORT_1; - poke32(DMA_ABORT_INTERRUPT, reg); - - /* Disable DMA Power, if a former application left it on */ - sm750_enable_dma(0); - } - /* We can add more initialization as needed. */ return 0;
diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h
index ee2e9d90f7dd..2a13debc179f 100644
--- a/drivers/staging/sm750fb/ddk750_chip.h
+++ b/drivers/staging/sm750fb/ddk750_chip.h@@ -76,13 +76,6 @@ struct initchip_param { */ unsigned short master_clock; - /* - * 0 = leave all engine state untouched. - * 1 = make sure they are off: 2D, Overlay, - * video alpha, alpha, hardware cursors - */ - unsigned short set_all_eng_off; - /* * 0 = Do not reset the memory controller * 1 = Reset the memory controller
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index c2d2864f135b..127db29883d2 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c@@ -848,7 +848,6 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src) sm750_dev->init_parm.mem_clk = 0; sm750_dev->init_parm.master_clk = 0; sm750_dev->init_parm.power_mode = 0; - sm750_dev->init_parm.set_all_eng_off = 0; sm750_dev->init_parm.reset_memory = 1; /* defaultly turn g_hwcursor on for both view */
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index c42800313c6a..7ab13da5d7cc 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h@@ -44,7 +44,6 @@ struct init_status { ushort chip_clk; ushort mem_clk; ushort master_clk; - ushort set_all_eng_off; ushort reset_memory; };
--
2.54.0