Re: [PATCH 2/2] staging: sm750fb: rename setAllEngOff
From: Dan Carpenter <hidden>
Date: 2026-05-28 14:14:44
Also in:
linux-staging, lkml
On Thu, May 28, 2026 at 07:06:27PM +0530, Onish Sharma wrote:
quoted hunk ↗ jump to hunk
Rename setAllEngOff to set_all_eng_off to comply with kernel coding style and improve readability. Signed-off-by: Onish Sharma <redacted> --- drivers/staging/sm750fb/sm750.c | 2 +- drivers/staging/sm750fb/sm750.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 8f01b3c63fe8..716a8935f58d 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c@@ -848,7 +848,7 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src) sm750_dev->init_parm.mem_clk = 0; sm750_dev->init_parm.master_clk = 0; sm750_dev->init_parm.power_mode = 0; - sm750_dev->init_parm.setAllEngOff = 0; + sm750_dev->init_parm.set_all_eng_off = 0; sm750_dev->init_parm.reset_memory = 1; /* defaultly turn g_hwcursor on for both view */diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 0492b1afbb11..e8885133da2e 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h@@ -44,7 +44,7 @@ struct init_status { ushort chip_clk; ushort mem_clk; ushort master_clk; - ushort setAllEngOff; + ushort set_all_eng_off; ushort reset_memory; };
There are no users? Why not just delete it. regards, dan carpenter