[PATCH v3 4/4] staging: sm750fb: deduplicate fbinfo loop in suspend/resume
From: Ahmet Sezgin Duran <hidden>
Date: 2026-05-25 09:02:08
Also in:
linux-staging, lkml
Subsystem:
staging - silicon motion sm750 frame buffer driver, staging subsystem, the rest · Maintainers:
Sudip Mukherjee, Teddy Wang, Sudip Mukherjee, Greg Kroah-Hartman, Linus Torvalds
lynxfb_suspend() and lynxfb_resume() both walk sm750_dev->fbinfo[]
via duplicated per-index blocks for fbinfo[0] and fbinfo[1].
Replace each pair of blocks with a for-loop bounded by
sm750_dev->fb_count, the number of successfully registered
framebuffers.
No functional changes intended.
Signed-off-by: Ahmet Sezgin Duran <redacted>
---
v3: Add braces around the multi-line if (info) body in the
suspend loop per Dan Carpenter's review.
Remove a stray blank line left behind in lynxfb_resume()
after the dedup.
Link: <https://lore.kernel.org/linux-staging/ahQB8C1gTr7LF0FO@stanley.mountain/ (local)>
v2: No changes.
drivers/staging/sm750fb/sm750.c | 36 +++++++++++++--------------------
1 file changed, 14 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index fff9c35ee7b0..1f6f92473c80 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c@@ -388,18 +388,19 @@ static int __maybe_unused lynxfb_suspend(struct device *dev) { struct fb_info *info; struct sm750_dev *sm750_dev; + int i; sm750_dev = dev_get_drvdata(dev); console_lock(); - info = sm750_dev->fbinfo[0]; - if (info) - /* 1 means do suspend */ - fb_set_suspend(info, 1); - info = sm750_dev->fbinfo[1]; - if (info) - /* 1 means do suspend */ - fb_set_suspend(info, 1); + + for (i = 0; i < sm750_dev->fb_count; i++) { + info = sm750_dev->fbinfo[i]; + if (info) { + /* 1 means do suspend */ + fb_set_suspend(info, 1); + } + } console_unlock(); return 0;
@@ -414,6 +415,7 @@ static int __maybe_unused lynxfb_resume(struct device *dev) struct lynxfb_par *par; struct lynxfb_crtc *crtc; struct lynx_cursor *cursor; + int i; sm750_dev = pci_get_drvdata(pdev);
@@ -421,21 +423,11 @@ static int __maybe_unused lynxfb_resume(struct device *dev) hw_sm750_inithw(sm750_dev, pdev); - info = sm750_dev->fbinfo[0]; - - if (info) { - par = info->par; - crtc = &par->crtc; - cursor = &crtc->cursor; - memset_io(cursor->vstart, 0x0, cursor->size); - memset_io(crtc->v_screen, 0x0, crtc->vidmem_size); - lynxfb_ops_set_par(info); - fb_set_suspend(info, 0); - } - - info = sm750_dev->fbinfo[1]; + for (i = 0; i < sm750_dev->fb_count; i++) { + info = sm750_dev->fbinfo[i]; + if (!info) + continue; - if (info) { par = info->par; crtc = &par->crtc; cursor = &crtc->cursor;
--
2.54.0