Re: [PATCH 5/5] staging: sm750fb: deduplicate fbinfo loop in suspend/resume

On 5/25/26 11:01 AM, Dan Carpenter wrote:

I was waiting to see if anyone had other comments bout this patchset
to decide if I should mention these minor nits.  But then I was
confused about v2 so I think there might end up being comments... :P

v2 was only about dropping another patch from series, no change for this 
patch. (would be better to talk this in v2 mails, but I guess it's no 
big deal.)

quoted

+
+	for (i = 0; i < sm750_dev->fb_count; i++) {
+		info = sm750_dev->fbinfo[i];
+		if (info)
+			/* 1 means do suspend */
+			fb_set_suspend(info, 1);

You didn't introduce this, but the rule is the multi-line indents get
curly braces for readabilitly even if they're not required.

Oh ok, just tried your suggestion, checkpatch didn't generate a warning. 
Got it.

quoted

-	}
+	for (i = 0; i < sm750_dev->fb_count; i++) {
+		info = sm750_dev->fbinfo[i];
  

Better to delete this blank line so the NULL check is next to the
assignment.

Got it.

I'll send v3, thanks for the review.

Regards,
Ahmet Sezgin Duran