Re: [PATCH v3] fbdev/hga: Request memory region before ioremap

Hi

Am 12.03.26 um 20:47 schrieb Helge Deller:

On 3/12/26 16:10, Thomas Zimmermann wrote:

quoted

Am 12.03.26 um 16:04 schrieb Hardik Phalet:

quoted

On Tue Mar 10, 2026 at 6:38 PM IST, Thomas Zimmermann wrote:

quoted

Hi,

thanks for the patch. Let's hope there are no conflicts with other
hardware.  IDK if anyone still uses this driver.

Hi Thomas,

Thanks for reviewing this.

Since I currently do not have access to the hardware needed to test the
change properly, I will drop this patch for now. I may revisit it 
once I
can validate the behavior on real hardware.

Good luck. That's the Hercules framebuffer driver. Finding such
ancient hardware that can run modern Linux is nigh impossible.

But we can merge the patch. If it breaks anyone's setup, they will 
send a bug report.

Helge will pick up the fix if he's ok with it.

No, I don't want to merge such patches any longer without any testing
on real hardware. There is no actual problem (else someone would have 
reported),
as such I don't see a benefit to apply it. Applying it just brings the 
risk
that we break it for someone.
So, NAK.

I believe I wrote about my opinion already in another patch?

Sorry, I wasn't aware.

I think we should rephrase that specific TODO item (which mentions the 
memory
region allocation) that only patches which have been tested are accepted.

There will likely no one show up here for testing unless it breaks there 
system. Which you won't know until you merge the patch.

If only pre-tested patches can go in, we should make a serious effort to 
remove drivers from fbdev. Because otherwise the driver code just sits 
around as liability.

Aggressively moving fbdev drivers into staging would be a good start IMHO.

Best regards
Thomas

Helge

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)