Re: [PATCH] staging: fbtft: fb_tinylcd: replace udelay() with usleep_range()

On Wed, Mar 11, 2026 at 02:24:07PM +0000, Anas Iqbal wrote:

Replace udelay() with usleep_range() for a 250 microsecond delay
as recommended by checkpatch.pl. usleep_range() avoids busy
waiting and allows the scheduler to schedule other tasks.

Now, read README here:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/staging/fbtft/README
and act accordingly.

If you have been mentored on this, show the above link to your mentors.

...

 	write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
-		       0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
+		  0x00, 0x35, 0x33, 0x00, 0x00, 0x00);

Use the common sense here. This change won't be accepted.

...

-	udelay(250);
+	usleep_range(250, 500);

No.

-- 
With Best Regards,
Andy Shevchenko