Re: [PATCH v2 09/13] lib/fonts: Compare font data for equality with font_data_is_equal()

From
Thomas Zimmermann <tzimmermann@suse.de>
Date
2026-03-05 09:31:21
Also in
dri-devel, lkml
Reply to
Nathan Chancellor, 2026-03-05
Hi

Am 05.03.26 um 01:23 schrieb Nathan Chancellor:
[...]
quoted
  
+static bool font_data_is_internal(font_data_t *fd)
+{
+	return is_kernel_rodata((unsigned long)fd);
+}
+
[...]
quoted
This breaks the build when CONFIG_FONT_SUPPORT is a module.

   $ cat allno.config
   CONFIG_MODULES=y
   CONFIG_DRM=m
   CONFIG_DRM_PANIC=y

   $ make -skj"$(nproc)" ARCH=x86_64 CROSS_COMPILE=x86_64-linux- KCONFIG_ALLCONFIG=1 allnoconfig all
   ERROR: modpost: "__end_rodata" [lib/fonts/font.ko] undefined!
   make[4]: *** [scripts/Makefile.modpost:147: Module.symvers] Error 1
   ...

   $ scripts/config -s FONT_SUPPORT
   m
Thanks for testing. The attached patch fixes the problem for me. Could you please test?

Best regards
Thomas
quoted
Cheers,
Nathan


+	if (font_data_size(lhs) != font_data_size(rhs))
+		return false;
+	if (FNTSUM(lhs) && FNTSUM(rhs) && FNTSUM(lhs) != FNTSUM(rhs))
+		return false;
+
+	return !memcmp(lhs, rhs, FNTSIZE(lhs));
+}
+EXPORT_SYMBOL_GPL(font_data_is_equal);
+
  /*
   * Font lookup
   */
-- 
2.53.0
-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)

Attachments

Thread (23 messages) 23 messages, 3 authors, last reply 2026-03-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help