[PATCH 2/6] staging: sm750fb: sm750_hw_fillrect: propagate de_wait() error
flat view
STALE217d
From: Soham Kute <hidden>
Date: 2026-03-04 17:35:41
Also in:
linux-staging, lkml
Subsystem:
staging - silicon motion sm750 frame buffer driver, staging subsystem, the rest · Maintainers:
Sudip Mukherjee, Teddy Wang, Sudip Mukherjee, Greg Kroah-Hartman, Linus Torvalds
Propagate the error from accel->de_wait() instead of returning -1. The caller treats all non-zero return values as failure. Signed-off-by: Soham Kute <redacted> --- drivers/staging/sm750fb/sm750_accel.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 046b9282b24a..1bd0502db039 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c@@ -90,14 +90,12 @@ int sm750_hw_fillrect(struct lynx_accel *accel, u32 color, u32 rop) { u32 de_ctrl; + int ret; - if (accel->de_wait() != 0) { - /* - * int time wait and always busy,seems hardware - * got something error - */ + ret = accel->de_wait(); + if (ret) { pr_debug("De engine always busy\n"); - return -1; + return ret; } write_dpr(accel, DE_WINDOW_DESTINATION_BASE, base); /* dpr40 */
--
2.34.1