Re: [PATCH 13/13] lib/fonts: Remove internal symbols and macros from public header file

Hi Thomas,

kernel test robot noticed the following build errors:

[auto build test ERROR on 0082025812a31eda451fb14f13f52683ed375c49]

url:    https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/fbdev-Declare-src-parameter-of-fb_pad_-helpers-as-constant/20260218-164243
base:   0082025812a31eda451fb14f13f52683ed375c49
patch link:    https://lore.kernel.org/r/20260218083855.10743-14-tzimmermann%40suse.de
patch subject: [PATCH 13/13] lib/fonts: Remove internal symbols and macros from public header file
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20260219/202602191044.XKx5ACdn-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260219/202602191044.XKx5ACdn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot [off-list ref]
| Closes: https://lore.kernel.org/oe-kbuild-all/202602191044.XKx5ACdn-lkp@intel.com/ (local)

All errors (new ones prefixed by >>):

   In file included from arch/powerpc/kernel/btext.c:23:
   arch/powerpc/kernel/btext.c: In function 'draw_byte':

quoted

arch/powerpc/kernel/btext.c:467:46: error: 'font_sun_8x16' undeclared (first use in this function); did you mean 'font_vga_8x16'?

     467 |         const unsigned char *font = PTRRELOC(font_sun_8x16.data) + font_index;
         |                                              ^~~~~~~~~~~~~
   arch/powerpc/include/asm/setup.h:19:34: note: in definition of macro 'PTRRELOC'
      19 | #define PTRRELOC(x)     ((typeof(x)) add_reloc_offset((unsigned long)(x)))
         |                                  ^
   arch/powerpc/kernel/btext.c:467:46: note: each undeclared identifier is reported only once for each function it appears in
     467 |         const unsigned char *font = PTRRELOC(font_sun_8x16.data) + font_index;
         |                                              ^~~~~~~~~~~~~
   arch/powerpc/include/asm/setup.h:19:34: note: in definition of macro 'PTRRELOC'
      19 | #define PTRRELOC(x)     ((typeof(x)) add_reloc_offset((unsigned long)(x)))
         |                                  ^


vim +467 arch/powerpc/kernel/btext.c

7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  462  
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  463  static noinline void draw_byte(unsigned char c, long locX, long locY)
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  464  {
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  465  	unsigned char *base	= calc_base(locX << 3, locY << 4);
0ebc7feae79ac0 Dr. David Alan Gilbert 2023-08-25  466  	unsigned int font_index = c * 16;
b94b7356756164 Finn Thain             2025-11-10 @467  	const unsigned char *font = PTRRELOC(font_sun_8x16.data) + font_index;
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  468  	int rb			= dispDeviceRowBytes;
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  469  
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  470  	rmci_maybe_on();
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  471  	switch(dispDeviceDepth) {
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  472  	case 24:
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  473  	case 32:
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  474  		draw_byte_32(font, (unsigned int *)base, rb);
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  475  		break;
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  476  	case 15:
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  477  	case 16:
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  478  		draw_byte_16(font, (unsigned int *)base, rb);
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  479  		break;
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  480  	case 8:
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  481  		draw_byte_8(font, (unsigned int *)base, rb);
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  482  		break;
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  483  	}
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  484  	rmci_maybe_off();
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  485  }
7191b615759ec1 Benjamin Herrenschmidt 2013-07-25  486  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki