Thread (13 messages) 13 messages, 3 authors, 2026-01-06

Re: [PATCH v1 0/4] staging: fbtft: reduce stack usage by avoiding large write_reg() varargs

flat view

From: Andy Shevchenko <hidden>
Date: 2026-01-05 16:32:17
Also in: dri-devel, linux-staging

On Sun, Jan 04, 2026 at 07:06:34PM +0800, Sun Jian wrote:
This series fixes clang `-Wframe-larger-than=1024` warnings in the fbtft
staging drivers.

The warnings are triggered by very large `write_reg()`/`write_register()`
varargs calls, which result in excessive stack usage.

Switch the affected paths to send a u8 command byte followed by the u8
payload using `fbtft_write_buf_dc()`. The register values and ordering are
kept unchanged; only the transfer method is updated.
Looking at the patches I think this is wrong. W.o. detailed test pattern
provided and the list of the devices, NAK.

If you want to address a warning without HW being accessible, perhaps you just
need a simple bump in the Makefile as an exception, however it's also doubtful
as it will hide a potential issue with the stack in the future.

-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help