fbdev: fix fb_pad_unaligned_buffer mask

Started by Osama Abdelkader on Jan 27, 2026 · 2 messages from 2 authors · Last reply Jan 27, 2026

Subsystems (3)

Maintainers (3)

STALE291d

open the first message on its own page

Message details and related content
mask is u8, so it should use 0xff instead of 0xfff
Signed-off-by: Osama Abdelkader <redacted>
---
 drivers/video/fbdev/core/fbmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
index eff757ebbed1..cf199038f069 100644
--- a/drivers/video/fbdev/core/fbmem.c
+++ b/drivers/video/fbdev/core/fbmem.c
@@ -100,7 +100,7 @@ EXPORT_SYMBOL(fb_pad_aligned_buffer);
 void fb_pad_unaligned_buffer(u8 *dst, u32 d_pitch, u8 *src, u32 idx, u32 height,
 				u32 shift_high, u32 shift_low, u32 mod)
 {
-	u8 mask = (u8) (0xfff << shift_high), tmp;
+	u8 mask = (u8) (0xff << shift_high), tmp;
 	int i, j;
 
 	for (i = height; i--; ) {
-- 
2.43.0
Message details and related content
On 1/27/26 20:30, Osama Abdelkader wrote:
mask is u8, so it should use 0xff instead of 0xfff
Signed-off-by: Osama Abdelkader <redacted>
---
  drivers/video/fbdev/core/fbmem.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
applied.

Thanks!
Helge
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help