[PATCH v3] staging: sm750fb: Convert sw_i2c_read_sda to return bool
flat view
STALE265d
From: Karthikey Kadati <hidden>
Date: 2026-01-14 17:17:59
Also in:
linux-staging, lkml
Subsystem:
staging - silicon motion sm750 frame buffer driver, staging subsystem, the rest · Maintainers:
Sudip Mukherjee, Teddy Wang, Sudip Mukherjee, Greg Kroah-Hartman, Linus Torvalds
The sw_i2c_read_sda() function currently returns unsigned char (1 or 0). Standardize it to return bool (true or false) to match kernel standards. Signed-off-by: Karthikey Kadati <redacted> --- v3: - Add version history (Reported by kernel test robot). v2: - Fix invalid "Unix Antigravity" Signed-off-by. - Submit as standalone patch (detached from unrelated series). drivers/staging/sm750fb/ddk750_swi2c.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c
index 0ef8d4ff2..9d48673d3 100644
--- a/drivers/staging/sm750fb/ddk750_swi2c.c
+++ b/drivers/staging/sm750fb/ddk750_swi2c.c@@ -180,7 +180,7 @@ static void sw_i2c_sda(unsigned char value) * Return Value: * The SDA data bit sent by the Slave */ -static unsigned char sw_i2c_read_sda(void) +static bool sw_i2c_read_sda(void) { unsigned long gpio_dir; unsigned long gpio_data;
@@ -196,9 +196,9 @@ static unsigned char sw_i2c_read_sda(void) /* Now read the SDA line */ gpio_data = peek32(sw_i2c_data_gpio_data_reg); if (gpio_data & (1 << sw_i2c_data_gpio)) - return 1; + return true; else - return 0; + return false; } /*
--
2.43.0