Re: [PATCH 1/6] video/logo: remove orphan .pgm Makefile rule

From
David Heidelberg <david@ixit.cz>
Date
2026-01-02 16:43:33
Also in
dri-devel, linux-sh, lkml
Reply to
Vincent Mailhol, 2025-12-30
On 30/12/2025 23:20, Vincent Mailhol wrote:
The kernel has no actual grey-scale logos. And looking at the git
history, it seems that there never was one (or maybe there was in the
pre-git history? I did not check that far…)

Remove the Makefile rule for the .pgm grey scale images.
Great to see this series.

I think the Fixes: tag should still go here, even if it is not very specific.

David
quoted hunk ↗ jump to hunk
Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
---
  drivers/video/logo/Makefile | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/video/logo/Makefile b/drivers/video/logo/Makefile
index 895c60b8402e..8b67c4941a4c 100644
--- a/drivers/video/logo/Makefile
+++ b/drivers/video/logo/Makefile
@@ -30,8 +30,5 @@ $(obj)/%.c: $(src)/%.pbm $(obj)/pnmtologo FORCE
  $(obj)/%.c: $(src)/%.ppm $(obj)/pnmtologo FORCE
  	$(call if_changed,logo)
  
-$(obj)/%.c: $(src)/%.pgm $(obj)/pnmtologo FORCE
-	$(call if_changed,logo)
-
  # generated C files
-targets += *_mono.c *_vga16.c *_clut224.c *_gray256.c
+targets += *_mono.c *_vga16.c *_clut224.c
-- 
David Heidelberg
Thread (21 messages) 21 messages, 5 authors, last reply 2026-01-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help