Re: [PATCH] staging: sm750fb: rename fixId to fix_id

From
Greg KH <gregkh@linuxfoundation.org>
Date
2026-01-11 12:51:57
Also in
linux-staging
Reply to
Tejas Chaudhari, 2025-12-23
On Wed, Dec 24, 2025 at 12:57:03AM +0530, Tejas Chaudhari wrote:
quoted hunk ↗ jump to hunk
Rename the local fixId array to fix_id to follow
kernel naming conventions and fix a checkpatch
CamelCase warning.

No functional changes.

Signed-off-by: Tejas Chaudhari <redacted>
---
 drivers/staging/sm750fb/sm750.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 15b5de33b..7afb58561 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -740,7 +740,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
 		"kernel HELPERS prepared vesa_modes",
 	};
 
-	static const char *fixId[2] = {
+	static const char *fix_id[2] = {
 		"sm750_fb1", "sm750_fb2",
 	};
 
@@ -862,7 +862,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
 	fix->ywrapstep = crtc->ywrapstep;
 	fix->accel = FB_ACCEL_SMI;
 
-	strscpy(fix->id, fixId[index], sizeof(fix->id));
+	strscpy(fix->id, fix_id[index], sizeof(fix->id));
 
 	fix->smem_start = crtc->o_screen + sm750_dev->vidmem_start;
 	pr_info("fix->smem_start = %lx\n", fix->smem_start);
-- 
2.39.5 (Apple Git-154)
Does not apply to the tree anymore :(
Thread (2 messages) 2 messages, 2 authors, last reply 2026-01-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help