Re: [PATCH v3 3/4] fbdev: omapfb: Make FB_DEVICE dependency optional

From
Andy Shevchenko <hidden>
Date
2025-12-30 11:37:09
Also in
dri-devel, linux-omap, linux-staging, lkml
Reply to
Chintan Patel, 2025-12-30
On Mon, Dec 29, 2025 at 09:28:21PM -0800, Chintan Patel wrote:
omapfb provides several sysfs interfaces for framebuffer configuration
and debugging, but these are not required for the core driver.

Remove the hard dependency on CONFIG_FB_DEVICE and make sysfs support
optional by using dev_of_fbinfo() to obtain the backing device at runtime.
When FB_DEVICE is disabled, sysfs operations are skipped while the code
still builds and is type-checked.
...
+		struct device *dev = dev_of_fbinfo(fbdev->fbs[i]);
Still the same issue I pointed out in v2 review.
quoted hunk ↗ jump to hunk
 		int t;
+
+		if (!dev)
+			continue;
...
quoted hunk ↗ jump to hunk
+		struct device *dev = dev_of_fbinfo(fbdev->fbs[i]);
+
+		if (!dev)
+			continue;
Ditto.

-- 
With Best Regards,
Andy Shevchenko

Thread (20 messages) 20 messages, 6 authors, last reply 2026-01-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help