Re: [PATCH] fbdev/pxafb: Fix multiple clamped values in pxafb_adjust_timing

On Tue, Dec 02, 2025 at 08:36:08PM +0100, Helge Deller wrote:

On 12/2/25 19:36, Thorsten Blum wrote:

quoted

On 2. Dec 2025, at 19:28, Helge Deller wrote:

quoted

On 12/2/25 19:15, Thorsten Blum wrote:

...

quoted

quoted

How did you notice? Do you actually have the hardware and tested it?

I only compile-tested it.

I stumbled upon another driver with the same bug and then used grep to
search for other instances and found about 6 or 7, including this one.

Ok. But this then means, maybe the clamping isn't needed (since nobody complained),
or that nobody noticed because nobody uses the driver any longer.

I think it's a combination of factors: 1) rarely people have this hardware,
especially nowadays, to run more or less new kernel; 2) there are no conditions
happened that this patch fixes in their environments; 3) something else I
missed.


-- 
With Best Regards,
Andy Shevchenko