Re: [PATCH v3] fbdev: vga16fb: Request memory region.
From: Javier Garcia <hidden>
Date: 2025-11-15 07:31:25
Also in:
dri-devel, lkml
Hi, Helge Deller, added this extra space clean as a I received a bot msg. --- Javier Garcia On Sat, 8 Nov 2025 at 10:33, Javier Garcia [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This patch reserve and release VGA memory region. This align with Documentation/drm/todo.rst "Request memory regions in all fbdev drivers" I've tested with 32bits kernel and qemu. Signed-off-by: Javier Garcia <redacted> --- v1 -> v3: * Add space after comma. * v2 https://lore.kernel.org/lkml/20251028191615.2765711-1-rampxxxx@gmail.com/ (local) v1 -> v2: * Add release in vga16fb_remove , thanks Helge Deller. * v1 https://lore.kernel.org/lkml/20251016171845.1397153-1-rampxxxx@gmail.com/ (local) drivers/video/fbdev/vga16fb.c | 9 +++++++++ 1 file changed, 9 insertions(+)diff --git a/drivers/video/fbdev/vga16fb.c b/drivers/video/fbdev/vga16fb.c index eedab14c7d51..3b4c50d98ba6 100644 --- a/drivers/video/fbdev/vga16fb.c +++ b/drivers/video/fbdev/vga16fb.c@@ -1319,6 +1319,11 @@ static int vga16fb_probe(struct platform_device *dev) if (ret) return ret; + if (!request_mem_region(vga16fb_fix.smem_start, vga16fb_fix.smem_len, + "vga16b")) { + dev_err(&dev->dev, "vga16b: cannot reserve video memory at 0x%lx\n", + vga16fb_fix.smem_start); + } printk(KERN_DEBUG "vga16fb: initializing\n"); info = framebuffer_alloc(sizeof(struct vga16fb_par), &dev->dev);@@ -1398,6 +1403,8 @@ static int vga16fb_probe(struct platform_device *dev) err_ioremap: framebuffer_release(info); err_fb_alloc: + release_mem_region(vga16fb_fix.smem_start, + vga16fb_fix.smem_len); return ret; }@@ -1407,6 +1414,8 @@ static void vga16fb_remove(struct platform_device *dev) if (info) unregister_framebuffer(info); + release_mem_region(vga16fb_fix.smem_start, + vga16fb_fix.smem_len); } static const struct platform_device_id vga16fb_driver_id_table[] = { --2.50.1