Re: [PATCH] fbdev: udlfb: make CONFIG_FB_DEVICE optional

On 10/3/25 20:43, sukrut heroorkar wrote:

On Thu, Oct 2, 2025 at 8:52 AM Thomas Zimmermann [off-list ref] wrote:

quoted

Am 02.10.25 um 08:41 schrieb Helge Deller:

quoted

quoted

quoted

quoted

kernel test robot noticed the following build errors:

Did you compile and test this code before submitting this patch?

Yes, I had compiled & loaded the udlfb module with no errors. Please
let me know how to proceed in this case.

Look at the reported build error, which seems to happen in dev_dbg().
So, maybe in your testing you did not have debugging enabled?
The report contains the .config file with which you can test.

Can we rather make an effort to remove the udlfb driver entirely? A few
years back, there was one user who was still using it because of some
problems with the DRM udl driver. But I think we've addressed them. The
discussion is at [1].

Would be good to know if they issues/crashes really have been solved.
In [1] it seems the crashes still happened with DRM.

Should I send a patch series to completely remove udlfb, 

No. (at least not yet)

since [1] echoed that DRM udl driver is good enough?

quoted

[1] https://lore.kernel.org/dri-devel/20201130125200.10416-1-tzimmermann@suse.de/ (local)

Well, some people who do *NOT* actively use fbdev with the old
cards say the DRM replacements are "good enough".
For tThose people who really depend on fbdev and the speed it has
over DRM, the DRM "basic-drivers" are simply a nice-to-have-but-not-really-useable
type of drivers.
So, unless the really affected people say the DRM replacement
is fully usable, we need to keep the fbdev driver.

Helge