Re: [PATCH v2 02/15] drm/panel: panel-samsung-s6e63m0: Include <linux/of.h>

Hi

Am 16.07.25 um 01:43 schrieb Sebastian Reichel:

Hi,

On Tue, Jul 15, 2025 at 02:24:39PM +0200, Thomas Zimmermann wrote:

quoted

Include <linux/of.h> to declare device_property_read_u32(). Avoids
dependency on backlight header to include it.

device_property_*() is from <linux/property.h>, which is already
included in the following line...

Oh, that has been fixed already by commit d1a1807bae39 ("drm/panel: panel-samsung-s6e63m0: Include <linux/property.h>") from last October. Some of the patches in this series have been written a while ago. The one here is from Feb 2024. I'll double check the others, there might be similar cases. Thanks for reviewing.

Best regards
Thomas

Greetings,

-- Sebastian

quoted

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
  drivers/gpu/drm/panel/panel-samsung-s6e63m0.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c b/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c
index ea241c89593b..930948cb615f 100644
--- a/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c
+++ b/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c

@@ -16,6 +16,7 @@
  #include <linux/export.h>
  #include <linux/gpio/consumer.h>
  #include <linux/module.h>
+#include <linux/of.h>
  #include <linux/property.h>
  #include <linux/regulator/consumer.h>
  #include <linux/media-bus-format.h>

-- 
2.50.0

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)