Re: [PATCH] fbdev: fsl-diu-fb: add missing device_remove_file()

From
Helge Deller <deller@gmx.de>
Date
2025-03-09 02:28:33
Also in
dri-devel, lkml
Reply to
unknown sender, 2025-02-08
On 2/8/25 11:23, oushixiong1025@163.com wrote:
quoted hunk ↗ jump to hunk
From: Shixiong Ou <redacted>

Call device_remove_file() when driver remove.

Signed-off-by: Shixiong Ou <redacted>
---
  drivers/video/fbdev/fsl-diu-fb.c | 4 ++++
  1 file changed, 4 insertions(+)
diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c
index 5ac8201c3533..8c91af9a9156 100644
--- a/drivers/video/fbdev/fsl-diu-fb.c
+++ b/drivers/video/fbdev/fsl-diu-fb.c
@@ -1807,6 +1807,7 @@ static int fsl_diu_probe(struct platform_device *pdev)
  	if (ret) {
  		dev_err(&pdev->dev, "could not create sysfs file %s\n",
  			data->dev_attr.attr.name);
+		goto error;
this seems to miss calling free_irq() then at least...

Helge
Thread (2 messages) 2 messages, 2 authors, last reply 2025-03-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help