Re: [PATCH v5 RESEND 2/3] backlight: apple_dwi_bl: Add Apple DWI backlight driver
flat view
From: Daniel Thompson <danielt@kernel.org>
Date: 2025-02-13 20:51:19
Also in:
asahi, dri-devel, linux-arm-kernel, linux-devicetree, linux-leds, lkml
On Mon, Feb 03, 2025 at 07:50:33PM +0800, Nick Chan wrote:
quoted hunk ↗ jump to hunk
Add driver for backlight controllers attached via Apple DWI 2-wire interface, which is found on some Apple iPhones, iPads and iPod touches with a LCD display. Although there is an existing apple_bl driver, it is for backlight controllers on Intel Macs attached via PCI, which is completely different from the Samsung-derived DWI block. Signed-off-by: Nick Chan <redacted> --- drivers/video/backlight/Kconfig | 12 +++ drivers/video/backlight/Makefile | 1 + drivers/video/backlight/apple_dwi_bl.c | 123 +++++++++++++++++++++++++ 3 files changed, 136 insertions(+) create mode 100644 drivers/video/backlight/apple_dwi_bl.cdiff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig index 3614a5d29c71..c6168727900a 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig@@ -290,6 +290,18 @@ config BACKLIGHT_APPLE If you have an Intel-based Apple say Y to enable a driver for its backlight. +config BACKLIGHT_APPLE_DWI + tristate "Apple DWI 2-Wire Interface Backlight Driver" + depends on ARCH_APPLE || COMPILE_TEST + default y
Sorry to pick this up late and on a resend but... I can't come up with any justification for "default y" in this driver. Other than that this is a really tidy driver so with that changed please add: Reviewed-by: Daniel Thompson (RISCstar) <danielt@kernel.org> Daniel.