Re: [PATCH 2/3] Input: ads7846 - fix up the pendown GPIO setup on Nokia 770

From
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date
2025-01-06 07:02:30
Also in
linux-input, linux-omap, lkml
Reply to
Linus Walleij, 2025-01-02
On Thu, Jan 02, 2025 at 10:32:00PM +0100, Linus Walleij wrote:
On Thu, Jan 2, 2025 at 7:20 PM Aaro Koskinen [off-list ref] wrote:
quoted
The GPIO is set up as an IRQ, so request it as non-exclusive. Otherwise the
probe fails on Nokia 770 with:

    ads7846 spi2.0: failed to request pendown GPIO
    ads7846: probe of spi2.0 failed with error -16

Also the polarity is wrong. Fix it.

Fixes: 767d83361aaa ("Input: ads7846 - Convert to use software nodes")
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Reviewed-by: Linus Walleij <redacted>
Do we need to have this knowledge in the driver or can it be handled
in GPIO subsystem or affected board support? Requesting a GPIO with "in"
direction when it is also an interrupt source should be pretty common.

Thanks.

-- 
Dmitry
Thread (12 messages) 12 messages, 4 authors, last reply 2025-01-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help