Thread (22 messages) 22 messages, 2 authors, 2024-12-24

[PATCH fbtest 06/17] drawops: Remove always-false check in generic_fill_ellipse()

flat view
STALE653d

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2024-12-15 10:53:21
Subsystem: the rest · Maintainer: Linus Torvalds

x1 is u32, so it can never be negative.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drawops/generic.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drawops/generic.c b/drawops/generic.c
index ba8154b7ee34ca18..e81dea1ba23d6595 100644
--- a/drawops/generic.c
+++ b/drawops/generic.c
@@ -467,8 +467,6 @@ void generic_fill_ellipse(u32 x, u32 y, u32 a, u32 b, pixel_t pixel)
 		    dS2 += 4*b2;
 		    dT2 += 4*b2;
 		    x1--;
-		    if (x1 < 0)
-			break;
 		    y1++;
 		    fill_ellipse_points(x, y, x1, y1, pixel);
 		} else {
-- 
2.34.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help