Re: [PATCH 01/28] backlight: lcd: Rearrange code in fb_notifier_callback()
flat view
From: Daniel Thompson <hidden>
Date: 2024-09-03 14:55:00
Also in:
dri-devel, linux-omap
On Tue, Aug 20, 2024 at 11:22:39AM +0200, Thomas Zimmermann wrote:
First aqcuire the ops_lock and do al tests while holing it. Rearranges
s/aqcuire/acquire/ s/al/all/
quoted hunk ↗ jump to hunk
the code in lcd's fb_notifier_callback() to resemble the callback in the backlight module. This will simplify later changes to these tests. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/video/backlight/lcd.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-)diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c index ceec90ca758b..0cd0fa1b24f9 100644 --- a/drivers/video/backlight/lcd.c +++ b/drivers/video/backlight/lcd.c@@ -29,21 +29,25 @@ static int fb_notifier_callback(struct notifier_block *self, { struct lcd_device *ld; struct fb_event *evdata = data; + struct fb_info *info = evdata->info; ld = container_of(self, struct lcd_device, fb_notif); + mutex_lock(&ld->ops_lock); +
guard(mutex)(&ld->ops_lock); and eliminating all the goto code would be better here but not a huge deal. Daniel.