Re: [PATCH 2/9] of: property: add of_graph_get_next_port_endpoint()

From
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date
2024-08-09 02:29:45
Also in
dri-devel, linux-arm-kernel, linux-devicetree, linux-media, linux-omap, linux-sound
Reply to
Tomi Valkeinen, 2024-08-08
Hi Tomi
quoted
+/**
+ * of_graph_get_next_port_endpoint() - get next endpoint node in port.
+ * If it reached to end of the port, it will return NULL.
+ * @port: pointer to the target port node
+ * @endpoint: current endpoint node, or NULL to get first
+ *
+ * Return: An 'endpoint' node pointer with refcount incremented. Refcount
+ * of the passed @prev node is decremented.
+ */
Same issues here too. No "prev" parameter, and I suggest using 
"previous", not "current", to be consistent with 
of_graph_get_next_endpoint(). (or alternatively, change 
of_graph_get_next_endpoint()).

Oh, the declaration of the function uses "prev", but the implementation 
"endpoint". Please make the naming same.
Will fix in v2.
But it will use "prev" for param same as of_graph_get_next_endpoint()
quoted
+/**
+ * for_each_of_graph_port_endpoint - iterate over every endpoint in a port node
+ * @parent: parent device or ports node
Hmm, shouldn't the parent be a port node?
Thanks, will fix in v2


Thank you for your help !!

Best regards
---
Kuninori Morimoto
Thread (22 messages) 22 messages, 3 authors, last reply 2024-08-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help