Re: [PATCH] fbdev: omapfb: panel-sony-acx565akm: Simplify show_cabc_available_modes()

From
Helge Deller <deller@gmx.de>
Date
2024-08-28 18:09:00
Also in
dri-devel, kernel-janitors, linux-omap, lkml
Reply to
Christophe JAILLET, 2024-08-08
On 8/8/24 11:46, Christophe JAILLET wrote:
Use sysfs_emit_at() instead of snprintf() + custom logic.
Using sysfs_emit_at() is much more simple.

Also, sysfs_emit() is already used in this function, so using
sysfs_emit_at() is more consistent.

Also simplify the logic:
   - always add a space after an entry
   - change the last space into a '\n'

Finally it is easy to see that, given the size of cabc_modes, PAGE_SIZE
can not be reached.
So better keep everything simple (and correct).

Signed-off-by: Christophe JAILLET <redacted>
applied.

Thanks!
Helge
Thread (7 messages) 7 messages, 4 authors, last reply 2024-08-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help