Re: [PATCH] staging: vme_user: vme_bridge.h: Fix mutex without comment warning
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2024-07-31 07:44:53
Also in:
dri-devel, linux-staging, lkml
On Wed, Jul 31, 2024 at 01:06:05PM +0530, Riyan Dhiman wrote:
quoted hunk ↗ jump to hunk
Adhere to Linux kernel coding style Reported by checkpatch: CHECK: mutex definition without comment Signed-off-by: Riyan Dhiman <redacted> --- drivers/staging/vme_user/vme_bridge.h | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/drivers/staging/vme_user/vme_bridge.h b/drivers/staging/vme_user/vme_bridge.h index 9bdc41bb6602..0b1f05944f0d 100644 --- a/drivers/staging/vme_user/vme_bridge.h +++ b/drivers/staging/vme_user/vme_bridge.h@@ -28,6 +28,7 @@ struct vme_master_resource { struct vme_slave_resource { struct list_head list; struct vme_bridge *parent; + /* Locking for VME slave resources */
Are you sure about all of these? Please document them individually and put the proof of that in the changelog text. thanks, greg k-h