Re: [PATCH v2 20/43] drm/vkms: Use fbdev-shmem
From: Maíra Canal <mcanal@igalia.com>
Date: 2024-04-16 16:03:45
Also in:
dri-devel
On 4/10/24 10:02, Thomas Zimmermann wrote:
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Maíra Canal <mcanal@igalia.com> Best Regards, - Maíra
quoted hunk ↗ jump to hunk
Cc: Rodrigo Siqueira <redacted> Cc: Melissa Wen <melissa.srw@gmail.com> Cc: "Maíra Canal" <redacted> Cc: Haneen Mohammed <hamohammed.sa@gmail.com> Cc: Daniel Vetter <redacted> --- drivers/gpu/drm/vkms/vkms_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c index dd0af086e7fa9..8dc9dc13896e9 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b/drivers/gpu/drm/vkms/vkms_drv.c@@ -17,7 +17,7 @@ #include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_drv.h> -#include <drm/drm_fbdev_generic.h> +#include <drm/drm_fbdev_shmem.h> #include <drm/drm_file.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/drm_ioctl.h>@@ -223,7 +223,7 @@ static int vkms_create(struct vkms_config *config) if (ret) goto out_devres; - drm_fbdev_generic_setup(&vkms_device->drm, 0); + drm_fbdev_shmem_setup(&vkms_device->drm, 0); return 0;