Thread (16 messages) 16 messages, 5 authors, 2024-03-28

RE: EXTERNAL: Re: [PATCH v2 6/6] backlight: Remove fb_blank from struct backlight_properties

From: FLAVIO SULIGOI <f.suligoi@asem.it>
Date: 2024-03-20 09:00:18
Also in: dri-devel, linux-staging

HI Thomas,

...
quoted
quoted
Remove the field fb_blank from struct backlight_properties and remove
all code that still sets or reads it. Backlight blank status is now
tracked exclusively in struct backlight_properties.state.

The core backlight code keeps the fb_blank and state fields in sync,
but doesn't do anything else with fb_blank. Several drivers
initialize fb_blank to FB_BLANK_UNBLANK to enable the backlight. This
is already the default for the state field. So we can delete the
fb_blank code from core and drivers and rely on the state field.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Flavio Suligoi <f.suligoi@asem.it>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Tested-by: Flavio Suligoi <f.suligoi@asem.it>
Reviewed-by: Daniel Thompson <redacted>
Reviewed-by: Dan Carpenter <redacted>
...

Can you explain what are the differences between the version 1 and version
2 of the patch?

There are none. It's simply labeled v2 because it is part of the version
2 of this series.
...

Ah, ok. Sorry for my question, but having received only this email from the series,
I didn't understand why version two.
It's all clear now!

Best regards,
Flavio
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help