Hey Lee,

On Thu, Mar 14, 2024 at 10:20:35AM +0000, Lee Jones wrote:

On Wed, 13 Mar 2024, Uwe Kleine-König wrote:

quoted

On Wed, Mar 13, 2024 at 01:48:27PM +0100, Uwe Kleine-König wrote:

quoted

 struct lp8788_bl {
 	struct lp8788 *lp;
 	struct backlight_device *bl_dev;
-	struct lp8788_backlight_platform_data *pdata;
-	enum lp8788_bl_ctrl_mode mode;
 	struct pwm_device *pwm;

Actually this pwm_device member should be dropped, too. I wonder why
this even passes a W=1 build without a warning ...

@Lee: Feel free to fix this up while applying, or tell me if you prefer
an incremental fixup or a complete v2.

Either of the last 2 options would be fine.

I'd prefert a v2 then. Added to my today's todo list.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |