[PATCH RESEND 1/4] backlight: da9052: Fully initialize backlight_properties during probe
flat view
STALE969d
LANDED
From: Daniel Thompson <hidden>
Date: 2024-02-20 15:35:44
Also in:
dri-devel, lkml
Subsystem:
backlight class/subsystem, dialog semiconductor drivers, framebuffer layer, the rest · Maintainers:
Lee Jones, Daniel Thompson, Jingoo Han, Support Opensource, Helge Deller, Linus Torvalds
Status: Landed in mainline as 0285e9efaee8 on 2024-03-07.
Revision resend (2 revisions archived).
Revisions (2)
- v1
- resend current
props is stack allocated and the fields that are not explcitly set
by the probe function need to be zeroed or we'll get undefined behaviour
(especially so power/blank states)!
Fixes: 6ede3d832aaa ("backlight: add driver for DA9052/53 PMIC v1")
Signed-off-by: Daniel Thompson <redacted>
---
drivers/video/backlight/da9052_bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/da9052_bl.c b/drivers/video/backlight/da9052_bl.c
index 1cdc8543310b4..b8ff7046510eb 100644
--- a/drivers/video/backlight/da9052_bl.c
+++ b/drivers/video/backlight/da9052_bl.c@@ -117,6 +117,7 @@ static int da9052_backlight_probe(struct platform_device *pdev) wleds->led_reg = platform_get_device_id(pdev)->driver_data; wleds->state = DA9052_WLEDS_OFF; + memset(&props, 0, sizeof(struct backlight_properties)); props.type = BACKLIGHT_RAW; props.max_brightness = DA9052_MAX_BRIGHTNESS;
--
2.43.0