Thread (5 messages) 5 messages, 1 author, 2024-02-20
DORMANTno replies
Revisions (2)
  1. v1 current
  2. resend [diff vs current]

[PATCH 4/4] backlight: mp3309c: Fully initialize backlight_properties during probe

From: Daniel Thompson <hidden>
Date: 2024-02-20 15:30:23
Also in: dri-devel, lkml
Subsystem: backlight class/subsystem, framebuffer layer, mp3309c backlight driver, the rest · Maintainers: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller, Flavio Suligoi, Linus Torvalds

props is stack allocated and, although this driver initializes all the
fields that are not "owned" by the framework, we'd still like to ensure
it is zeroed to avoid problems from this driver if the fields change.

Signed-off-by: Daniel Thompson <redacted>
---
 drivers/video/backlight/mp3309c.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/mp3309c.c b/drivers/video/backlight/mp3309c.c
index 34d71259fac1d..cdf302d6f1cb5 100644
--- a/drivers/video/backlight/mp3309c.c
+++ b/drivers/video/backlight/mp3309c.c
@@ -373,6 +373,7 @@ static int mp3309c_probe(struct i2c_client *client)
 	chip->pdata = pdata;
 
 	/* Backlight properties */
+	memset(&props, 0, sizeof(struct backlight_properties));
 	props.brightness = pdata->default_brightness;
 	props.max_brightness = pdata->max_brightness;
 	props.scale = BACKLIGHT_SCALE_LINEAR;
-- 
2.43.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help