Re: [PATCH 2/4] backlight: lm3630a: Don't set bl->props.brightness in get_brightness
From: Daniel Thompson <hidden>
Date: 2024-02-20 14:03:32
Also in:
dri-devel, linux-arm-msm, linux-devicetree, lkml, phone-devel
On Tue, Feb 20, 2024 at 12:11:20AM +0100, Luca Weiss wrote:
There's no need to set bl->props.brightness, the get_brightness function
is just supposed to return the current brightness and not touch the
struct.
With that done we can also remove the 'goto out' and just return the
value.
Fixes: 0c2a665a648e ("backlight: add Backlight driver for lm3630 chip")
Signed-off-by: Luca Weiss <redacted>Reviewed-by: Daniel Thompson <redacted> Daniel.