Re: [PATCH 2/2] leds: expresswire: don't depend on NEW_LEDS
From: Daniel Thompson <hidden>
Date: 2024-02-15 11:48:35
Also in:
dri-devel, linux-leds, lkml
From: Daniel Thompson <hidden>
Date: 2024-02-15 11:48:35
Also in:
dri-devel, linux-leds, lkml
On Mon, Feb 12, 2024 at 09:03:26PM +0100, Duje Mihanović wrote:
The ExpressWire library does not depend on NEW_LEDS and selecting it from a subsystem other than LEDs may cause Kconfig warnings: WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE Depends on [n]: NEW_LEDS [=n] && GPIOLIB [=y] Selected by [y]: - BACKLIGHT_KTD2801 [=y] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=y] Move it out of the "if NEW_LEDS" block to allow selection from other subsystems (in particular backlight) without raising this warning. Link: https://lore.kernel.org/20240212111819.936815-1-arnd@kernel.org (local) Reported-by: Arnd Bergmann <arnd@arndb.de> Suggested-by: Daniel Thompson <redacted> Fixes: 25ae5f5f4168 ("leds: Introduce ExpressWire library") Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
Reviewed-by: Daniel Thompson <redacted> Daniel.