Re: [PATCH 11/13] fbdev: omapfb: use of_graph_get_next_port()
From: kernel test robot <hidden>
Date: 2024-01-27 15:58:35
Also in:
alsa-devel, linux-devicetree, linux-media, linux-sound, oe-kbuild-all
Hi Kuninori, kernel test robot noticed the following build warnings: [auto build test WARNING on broonie-sound/for-next] [also build test WARNING on linus/master v6.8-rc1 next-20240125] [cannot apply to robh/for-next drm-misc/drm-misc-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Kuninori-Morimoto/of-property-add-port-base-loop/20240123-081427 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/874jf4ud77.wl-kuninori.morimoto.gx%40renesas.com patch subject: [PATCH 11/13] fbdev: omapfb: use of_graph_get_next_port() config: i386-buildonly-randconfig-003-20240127 (https://download.01.org/0day-ci/archive/20240127/202401272336.CCkvpjde-lkp@intel.com/config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240127/202401272336.CCkvpjde-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot [off-list ref] | Closes: https://lore.kernel.org/oe-kbuild-all/202401272336.CCkvpjde-lkp@intel.com/ (local) All warnings (new ones prefixed by >>): drivers/video/fbdev/omap2/omapfb/dss/dss.c: In function 'dss_init_ports': drivers/video/fbdev/omap2/omapfb/dss/dss.c:925:9: error: implicit declaration of function 'of_graph_get_next_port'; did you mean 'of_get_next_parent'? [-Werror=implicit-function-declaration] port = of_graph_get_next_port(parent, NULL); ^~~~~~~~~~~~~~~~~~~~~~ of_get_next_parent
quoted
drivers/video/fbdev/omap2/omapfb/dss/dss.c:925:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
port = of_graph_get_next_port(parent, NULL);
^
drivers/video/fbdev/omap2/omapfb/dss/dss.c:956:10: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
(port = of_graph_get_next_port(parent, port)) != NULL);
^
drivers/video/fbdev/omap2/omapfb/dss/dss.c: In function 'dss_uninit_ports':
drivers/video/fbdev/omap2/omapfb/dss/dss.c:972:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
port = of_graph_get_next_port(parent, NULL);
^
drivers/video/fbdev/omap2/omapfb/dss/dss.c:1003:17: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
} while ((port = of_graph_get_next_port(parent, port)) != NULL);
^
cc1: some warnings being treated as errors
vim +925 drivers/video/fbdev/omap2/omapfb/dss/dss.c
915
916 static int dss_init_ports(struct platform_device *pdev)
917 {
918 struct device_node *parent = pdev->dev.of_node;
919 struct device_node *port;
920 int r, ret = 0;
921
922 if (parent == NULL)
923 return 0;
924
> 925 port = of_graph_get_next_port(parent, NULL);
926 if (!port)
927 return 0;
928
929 if (dss.feat->num_ports == 0)
930 return 0;
931
932 do {
933 enum omap_display_type port_type;
934 u32 reg;
935
936 r = of_property_read_u32(port, "reg", ®);
937 if (r)
938 reg = 0;
939
940 if (reg >= dss.feat->num_ports)
941 continue;
942
943 port_type = dss.feat->ports[reg];
944
945 switch (port_type) {
946 case OMAP_DISPLAY_TYPE_DPI:
947 ret = dpi_init_port(pdev, port);
948 break;
949 case OMAP_DISPLAY_TYPE_SDI:
950 ret = sdi_init_port(pdev, port);
951 break;
952 default:
953 break;
954 }
955 } while (!ret &&
956 (port = of_graph_get_next_port(parent, port)) != NULL);
957
958 if (ret)
959 dss_uninit_ports(pdev);
960
961 return ret;
962 }
963
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki