Re: [PATCH v6 1/4] pwm: rename pwm_apply_state() to pwm_apply_might_sleep()

From
Sean Young <sean@mess.org>
Date
2023-12-11 08:30:18
Also in
dri-devel, intel-gfx, linux-arm-kernel, linux-doc, linux-hwmon, linux-input, linux-leds, linux-media, linux-pwm, lkml, platform-driver-x86
Reply to
Uwe Kleine-König, 2023-12-09
On Sat, Dec 09, 2023 at 02:57:42PM +0100, Uwe Kleine-König wrote:
On Wed, Nov 29, 2023 at 09:13:34AM +0000, Sean Young wrote:
quoted
In order to introduce a pwm api which can be used from atomic context,
we will need two functions for applying pwm changes:

	int pwm_apply_might_sleep(struct pwm *, struct pwm_state *);
	int pwm_apply_atomic(struct pwm *, struct pwm_state *);

This commit just deals with renaming pwm_apply_state(), a following
commit will introduce the pwm_apply_atomic() function.

Acked-by: Hans de Goede <redacted>
Acked-by: Jani Nikula <redacted>
Acked-by: Lee Jones <lee@kernel.org>
Signed-off-by: Sean Young <sean@mess.org>
Not a in-detail-review, but I just noticed again, that we have

	K:      pwm_(config|apply_state|ops)

in MAINTAINERS. That one needs adaption, too.
Fixed in v7.

Thanks,

Sean
Thread (4 messages) 4 messages, 3 authors, last reply 2023-12-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help