Thread (77 messages) 77 messages, 7 authors, 2023-11-22

Re: [PATCH 06/32] fbdev/arcfb: Use generator macros for deferred I/O

From: Javier Martinez Canillas <javierm@redhat.com>
Date: 2023-11-16 10:16:51
Also in: dri-devel

Thomas Zimmermann [off-list ref] writes:
Implement the driver's fops with the generator macros for deferred
I/O. Only requires per-driver code for the on-scren scanout buffer.
The generated helpers implement reading, writing and drawing on top
of that. Also update the selected Kconfig tokens accordingly.

Actual support for deferred I/O is missing from the driver. So
writing to memory-mapped pages does not automatically update the
scanout buffer.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Jaya Kumar <jayalk@intworks.biz>
---
 drivers/video/fbdev/Kconfig |   5 +-
 drivers/video/fbdev/arcfb.c | 113 +++++++++---------------------------
 2 files changed, 27 insertions(+), 91 deletions(-)
The patch looks good to me from a high level point of view but it's not
trivial so it would be good if Jaya Kumar can review / test it as well.

Acked-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help