Thread (3 messages) 3 messages, 2 authors, 2023-11-17

Re: [PATCH 2/3] fbdev: ssd1307fb: Change "solomon,page-offset" property default value

From: Javier Martinez Canillas <javierm@redhat.com>
Date: 2023-11-17 22:18:54
Also in: dri-devel, lkml

Andy Shevchenko [off-list ref] writes:

Hello Andy,
On Thu, Nov 16, 2023 at 07:07:38PM +0100, Javier Martinez Canillas wrote:
quoted
This is used to specify the page start address offset of the display RAM.

The value is used as offset when setting the page start address with the
SSD130X_SET_PAGE_RANGE command, and the driver currently sets its value to
1 if the property is not present in the Device Tree.

But the datasheet mentions that the value on reset for the page start is a
0, so it makes more sense to also have 0 as the default value for the page
offset if the property is not present.

In fact, using a default value of 1 leads to the display not working when
the fbdev is attached to the framebuffer console.

Reported-by: Sahaj Sarup <redacted>
Closes?
There's no report in a mailing list or bug tracker to reference.
Fixes?
Since the default has been the same since the driver was merged,
it doesn't make that much sense for me to reference that commit.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help