Re: [PATCH 1/1] dt-bindings: backlight: mp3309c: remove two required properties
From: Conor Dooley <conor@kernel.org>
Date: 2023-10-20 15:59:34
Also in:
dri-devel, linux-devicetree, linux-leds, lkml
Yo, On Fri, Oct 20, 2023 at 03:54:33PM +0200, Flavio Suligoi wrote:
The two properties: - max-brightness - default brightness are not really required, so they can be removed from the "required" section.
Why are they not required? You need to provide an explanation.
Other changes: - improve the backlight working mode description, in the "description" section
- update the example, removing the "max-brightness" and introducing the "brightess-levels" property
Why is this more useful? Cheers, Conor.
quoted hunk ↗ jump to hunk
Signed-off-by: Flavio Suligoi <f.suligoi@asem.it> --- .../bindings/leds/backlight/mps,mp3309c.yaml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)diff --git a/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml b/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml index 4191e33626f5..527a37368ed7 100644 --- a/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml +++ b/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml@@ -14,8 +14,8 @@ description: | programmable switching frequency to optimize efficiency. It supports two different dimming modes: - - analog mode, via I2C commands (default) - - PWM controlled mode. + - analog mode, via I2C commands, as default mode (32 dimming levels) + - PWM controlled mode (optional) The datasheet is available at: https://www.monolithicpower.com/en/mp3309c.html@@ -50,8 +50,6 @@ properties: required: - compatible - reg - - max-brightness - - default-brightness unevaluatedProperties: false@@ -66,8 +64,8 @@ examples: compatible = "mps,mp3309c"; reg = <0x17>; pwms = <&pwm1 0 3333333 0>; /* 300 Hz --> (1/f) * 1*10^9 */ - max-brightness = <100>; - default-brightness = <80>; + brightness-levels = <0 4 8 16 32 64 128 255>; + default-brightness = <6>; mps,overvoltage-protection-microvolt = <24000000>; }; };-- 2.34.1
Attachments
- signature.asc [application/pgp-signature] 228 bytes