Re: [PATCH v3 1/9] vgacon: rework Kconfig dependencies
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2023-10-10 10:26:34
Also in:
dri-devel, linux-alpha, linux-efi, linux-hyperv, linux-mips, linux-riscv, linux-sh, linuxppc-dev, lkml, loongarch, sparclinux
Hi Arnd, On Mon, Oct 9, 2023 at 11:19 PM Arnd Bergmann [off-list ref] wrote:
From: Arnd Bergmann <arnd@arndb.de> The list of dependencies here is phrased as an opt-out, but this is missing a lot of architectures that don't actually support VGA consoles, and some of the entries are stale: - powerpc used to support VGA consoles in the old arch/ppc codebase, but the merged arch/powerpc never did - arm lists footbridge, integrator and netwinder, but netwinder is actually part of footbridge, and integrator does not appear to have an actual VGA hardware, or list it in its ATAG or DT. - mips has a few platforms (malta, sibyte, and sni) that initialize screen_info, on everything else the console is selected but cannot actually work. - csky, hexgagon, loongarch, nios2, riscv and xtensa are not listed in the opt-out table and declare a screen_info to allow building vga_con, but this cannot work because the console is never selected. Replace this with an opt-in table that lists only the platforms that remain. This is effectively x86, plus a couple of historic workstation and server machines that reused parts of the x86 system architecture. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Khalid Aziz <khalid@gonehiking.org> Acked-by: Helge Deller <deller@gmx.de> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for your patch! Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> A few suggestions for simplification below...
quoted hunk ↗ jump to hunk
--- a/drivers/video/console/Kconfig +++ b/drivers/video/console/Kconfig@@ -7,9 +7,9 @@ menu "Console display driver support" config VGA_CONSOLE bool "VGA text console" if EXPERT || !X86 - depends on !4xx && !PPC_8xx && !SPARC && !M68K && !PARISC && !SUPERH && \ - (!ARM || ARCH_FOOTBRIDGE || ARCH_INTEGRATOR || ARCH_NETWINDER) && \ - !ARM64 && !ARC && !MICROBLAZE && !OPENRISC && !S390 && !UML + depends on ALPHA || IA64 || X86 || \ + (ARM && ARCH_FOOTBRIDGE) || \
You can drop "ARM &&", as it is implied by ARCH_FOOTBRIDGE.
+ (MIPS && (MIPS_MALTA || SIBYTE_BCM112X || SIBYTE_SB1250 || SIBYTE_BCM1x80 || SNI_RM))
Likewise for "MIPS &&". The 3 SIBYTE dependencies can be replaced by SIBYTE_SB1xxx_SOC.
select APERTURE_HELPERS if (DRM || FB || VFIO_PCI_CORE)
default y
help
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds