On Thursday, October 5, 2023 10:40:41 PM CEST Krzysztof Kozlowski wrote:

On 05/10/2023 20:49, Duje Mihanović wrote:

quoted

+	gpiod_set_value(ktd2801->desc, 0);
+	udelay(EOD_H);

Hm, why device is kept off after this? Setting 0 means enable GPIO is
logical 0.

...

quoted

+	ktd2801->desc = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);

OUT_LOW is keep it disabled, so is this intentional?

I initially wrote the driver to expect GPIO_ACTIVE_LOW, a decision which in 
retrospect indeed makes no sense. If you have no objections, I'll change it to 
expect GPIO_ACTIVE_HIGH.

Regards,
Duje