RE: [PATCH v3 1/2] dt-bindings: backlight: Add MPS MP3309C
From: Flavio Suligoi <f.suligoi@asem.it>
Date: 2023-10-03 09:43:25
Also in:
dri-devel, linux-devicetree, linux-leds, lkml
From: Flavio Suligoi <f.suligoi@asem.it>
Date: 2023-10-03 09:43:25
Also in:
dri-devel, linux-devicetree, linux-leds, lkml
Hi Daniel, ...
quoted
+required: + - compatible + - reg + - max-brightnessWhy is this mandatory? There's no point in setting max-brightness when running in I2C mode (max- brightness should default to 31 in that case).quoted
+ - default-brightnessAgain. I'm not clear why this needs to be mandatory.
Ok, you are right, I'll remove max-brightness and default-brightness from required properties list.
I think to change these properties, for the pwm dimming, into a clearer:
- brightness-levels (uint32)
- default-brightness-levels (uint32).
For example:
brightness-levels:
description:
Number of brightness levels. The actual brightness
level (PWM duty cycle) will be interpolated from 0 to this value.
0 means a 0% duty cycle (darkest/off), while the brightness-levels represents
a 100% duty cycle (brightest).
$ref: /schemas/types.yaml#/definitions/uint32
default-brightness-level:
description:
The default brightness level (from 0 to brightness-levels)
$ref: /schemas/types.yaml#/definitions/uint32
Example:
brightness-levels = <10>;
default-brightness-level = <6>;
What do you think about this solution?
Daniel.
Thanks for your help, Flavio