Thread (4 messages) 4 messages, 3 authors, 2023-09-26

Re: [PATCH v2] backlight: pwm_bl: Disable PWM on shutdown and suspend

From: Uwe Kleine-König <hidden>
Date: 2023-09-26 08:53:48
Also in: dri-devel, linux-pwm

On Tue, Sep 26, 2023 at 10:46:12AM +0200, Uwe Kleine-König wrote:
Since commit 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once
per backlight toggle") calling pwm_backlight_power_off() doesn't disable
the PWM any more. However this is necessary to suspend because PWM
drivers usually refuse to suspend if they are still enabled.

Also adapt shutdown to disable the PWM for similar reasons.

Fixes: 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once per backlight toggle")
Reported-by: Aisheng Dong <aisheng.dong@nxp.com>
Tested-by: Aisheng Dong <redacted>
The two email addresses should actually be identical, the first one is
the right one. (Failure introduced by
https://lore.kernel.org/dri-devel/DB9PR04MB8477D4BBF1B31035789DA08680869@DB9PR04MB8477.eurprd04.prod.outlook.com (local)
and picked up by b4.) Lee, can you fixup or should I resend?

Best regards
Uwe


-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help