Thread (23 messages) 23 messages, 4 authors, 2023-09-07

Re: [PATCH 2/7] fbdev/mmp/mmpfb: Do not display boot-up logo

From: Javier Martinez Canillas <javierm@redhat.com>
Date: 2023-09-06 09:55:00
Also in: dri-devel, lkml

Thomas Zimmermann [off-list ref] writes:
The fbcon module takes care of displaying the logo, if any. Remove
the code form mmpfb. If we want to display the logo without fbcon,
s/form/from
we should implement this in the fbdev core code.
The commit message says the same than patch #1 but the driver will behave
differently right? That is, won't only show the logo when fbcon is not
enabled but unconditionally? So the logo will be duplicated when fbcon is
enabled?

If I understood that correctly, probably you should mention that in the
commit message since removing the fb_show_logo() will make the driver to
behave correctly.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
Acked-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help