On 2023/8/3 16:52, Daniel Vetter wrote:

On Thu, Aug 03, 2023 at 10:40:35AM +0200, Daniel Vetter wrote:

quoted

On Thu, Aug 03, 2023 at 10:09:39AM +0800, GUO Zihua wrote:

quoted

fbcon_registered_fb and fbcon_num_registered_fb is not referred outside
drivers/video/fbdev/core/fbcon.c, so make them static.

Signed-off-by: GUO Zihua <redacted>

Applied both of your patches to drm-misc-next.

Correction, I dropped the agpgart patch again because amd gart x86 arch
code needs that symbol.

Thanks Daniel. Blind enough to not found this usage while making the
patch, sorry for the burden.

quoted

-Daniel

quoted

---
 drivers/video/fbdev/core/fbcon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index 887fad44e7ec..976900d6893c 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c

@@ -102,8 +102,8 @@ enum {
 
 static struct fbcon_display fb_display[MAX_NR_CONSOLES];
 
-struct fb_info *fbcon_registered_fb[FB_MAX];
-int fbcon_num_registered_fb;
+static struct fb_info *fbcon_registered_fb[FB_MAX];
+static int fbcon_num_registered_fb;
 
 #define fbcon_for_each_registered_fb(i)		\
 	for (i = 0; WARN_CONSOLE_UNLOCKED(), i < FB_MAX; i++)		\

-- 
2.17.1

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

-- 
Best
GUO Zihua