On 8/31/23 11:02, Helge Deller wrote:

On 8/31/23 10:51, Daniel Vetter wrote:

quoted

On Thu, Aug 31, 2023 at 08:44:59AM +0200, Jonathan Neuschäfer wrote:

quoted

On Wed, Aug 30, 2023 at 09:10:26AM +0200, Thomas Zimmermann wrote:

quoted

Hi

Am 29.08.23 um 22:02 schrieb Jonathan Neuschäfer:

quoted

The files fbmem.c, fb_defio.c, fbsysfs.c, fbmon.c, modedb.c, and
fbcmap.c were moved to drivers/video/fbdev, and subsequently to
drivers/video/fbdev/core, in the commits listed below.

Reported by kalekale in #kernel (Libera IRC).

Fixes: f7018c213502 ("video: move fbdev to drivers/video/fbdev")
Fixes: 19757fc8432a ("fbdev: move fbdev core files to separate directory")
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

IMHO these comments might just be removed.

I think it's nice to have some sort of visual separation between groups
of functions in fb.h, which these comments provide at the moment.
Therefore I'm currently leaning towards my patch as it is, but I'm
willing to have my mind changed and do a v2 which just removes the
comments.

Just the filename without the full path maybe?

Yes, I'd prefer that as well.

I've manually changed it and applied the patch to the fbdev git tree.

Thanks!
Helge