Thread (9 messages) 9 messages, 4 authors, 2023-11-13

Re: [PATCH 2/3] video: fbdev: ssd1307fb: Print the PWM's label instead of its number

From: Helge Deller <deller@gmx.de>
Date: 2023-07-31 12:42:54
Also in: dri-devel

On 7/28/23 16:58, Uwe Kleine-König wrote:
struct pwm_device::pwm is a write-only variable in the pwm core and used
nowhere apart from this and another dev_dbg. So it isn't useful to
identify the used PWM. Emit the PWM's label instead in the debug
message.

Signed-off-by: Uwe Kleine-König <redacted>
applied.

Thanks!
Helge
quoted hunk ↗ jump to hunk
---
  drivers/video/fbdev/ssd1307fb.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index 11c373798279..46881a691549 100644
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -399,8 +399,8 @@ static int ssd1307fb_init(struct ssd1307fb_par *par)
  		/* Enable the PWM */
  		pwm_enable(par->pwm);

-		dev_dbg(&par->client->dev, "Using PWM%d with a %lluns period.\n",
-			par->pwm->pwm, pwm_get_period(par->pwm));
+		dev_dbg(&par->client->dev, "Using PWM %s with a %lluns period.\n",
+			par->pwm->label, pwm_get_period(par->pwm));
  	}

  	/* Set initial contrast */
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help