On 7/13/23 06:21, Miguel Ojeda wrote:

On Thu, Jul 13, 2023 at 3:03 PM Thomas Zimmermann [off-list ref] wrote:

quoted

Most fbdev drivers depend on framebuffer_alloc() to initialize the
allocated memory to 0. Document this guarantee.

Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Helge Deller <deller@gmx.de>

Thanks for sending this! Maybe this would be best earlier in the
series, so that later patches make more sense (since they use the
guarantee), but it is not a big deal.

quoted

+ * aligned to sizeof(long). Both, the instance of struct fb_info and
+ * the driver private data, are cleared to zero.

I think both commas may be best omitted (but I am not a native speaker).

Yes, it would be better to omit them.

Reviewed-by: Miguel Ojeda <ojeda@kernel.org>

Cheers,
Miguel

-- 
~Randy