Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols
From: Javier Martinez Canillas <javierm@redhat.com>
Date: 2023-07-03 08:50:58
Also in:
dri-devel, lkml
From: Javier Martinez Canillas <javierm@redhat.com>
Date: 2023-07-03 08:50:58
Also in:
dri-devel, lkml
Thomas Zimmermann [off-list ref] writes: [...]
quoted
quoted
quoted
config FB_DEVICE bool "Provide legacy /dev/fb* device" - depends on FB + select FB_COREThis should depend on FB_CORE.Yes, already fixed in v3 too. I did a select to prevent symbol circular dependencies but doing that lead to CONFIG_FB_CORE=y even if CONFIG_DRM was set as a module. But with the "select FB_CORE if DRM_FBDEV_EMULATION" in the DRM symbol as Arnd suggested, I was able to have FB_DEVICE to depend on FB_CORE again.BTW, where does this item now show up in the menu? It used to be in the framebuffer menu. It's now in the graphics-drivers menu?
No, it's still in the framebuffer menu. But after the FB_CORE split the menuconfig ends broken (no sub-level for fbdev drivers anymore). I was talking with Arnd and Geert about this. I think that will pause this series and instead first focus on cleaning up the fbdev Kconfig, then it should be easier to add the FB_CORE on top of that.
Best regards Thomas
-- Best regards, Javier Martinez Canillas Core Platforms Red Hat